Disable mdblocales by default in configure#1651
Open
tuhaihe wants to merge 2 commits intoapache:mainfrom
Open
Conversation
12 tasks
yjhjstz
reviewed
Mar 31, 2026
| sed -i '' '/define CONFIGURE_ARGS/s,\([^\\]\)\\\$\$,\1\\\\$$,g' src/include/pg_config.h | ||
| ;; | ||
| *) | ||
| sed -i '/define CONFIGURE_ARGS/s,\([^\\]\)\\\$\$,\1\\\\$$,g' src/include/pg_config.h |
Member
There was a problem hiding this comment.
this is for darwin platform, need keep it.
Member
Author
There was a problem hiding this comment.
@zhangyue1818 Hi, could you take a look at this? The best way is to define in configure.ac, then regenerate configure, not edit it directly. Or else, cannot make sure it's not covered in the future.
leborchuk
approved these changes
Mar 31, 2026
Contributor
leborchuk
left a comment
leborchuk
left a comment
There was a problem hiding this comment.
Yep, configure already use --with-mdblocales https://github.com/apache/cloudberry/blob/main/devops/build/automation/cloudberry/scripts/configure-cloudberry.sh#L149
--without-mdblocales looks like a mistake and should be deleted
yjhjstz
requested changes
Apr 1, 2026
Changed the default value of `--with-mdblocales` from 'yes' to 'no' in configure.ac. This prevents enabling custom locales by default, which require additional packages and may cause compatibility issues across different system environments (e.g., Rocky Linux 8 vs 9 with different libc versions). Users who need mdblocales can explicitly enable it with `--with-mdblocales` option. Regenerated configure file using autoconf 2.69 on Rocky Linux 8.
tuhaihe
force-pushed
the
disable-mdblocales-patch
branch
from
e2dbdad to
5311489
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the default value of
--with-mdblocalesfrom 'yes' to 'no' in configure.ac. This prevents enabling custom locales by default, which require additional packages and may cause compatibility issues across different system environments (e.g., Rocky Linux 8 vs 9 with different libc versions). Users who need mdblocales can explicitly enable it with--with-mdblocalesoption.Regenerated configure file using autoconf 2.69 on Rocky Linux 8.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions